chore(toolbox-langchain): rename auth_tokens to auth_token_getters #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anubhav756
force-pushed
the
anubhav-auth-token-getter
branch
from
598a6f9 to
508c460
Compare
anubhav756
changed the title
twishabansal
approved these changes
Apr 21, 2025
anubhav756
force-pushed
the
anubhav-auth-token-getter
branch
from
508c460 to
a37e5cc
Compare
anubhav756
force-pushed
the
anubhav-auth-token-getter
branch
3 times, most recently
from
508c460 to
2388dc9
Compare
anubhav756
changed the title
anubhav756
changed the title
kurtisvg
changed the title
anubhav756
force-pushed
the
anubhav-auth-token-getter
branch
from
2388dc9 to
c1f1e27
Compare
…n(s) as add_auth_token_getter(s) This is to align with the toolbox-core APIs and also because the suffix of _getter(s) make these APIs more descriptive and accurate. It actively encourages best practices regarding token security and lifecycle management (like refresh logic), which is crucial for production systems.
anubhav756
force-pushed
the
anubhav-auth-token-getter
branch
from
c1f1e27 to
d0d61f5
Compare
Merged
anubhav756
added a commit
that referenced
this pull request
May 10, 2025
…lity This PR addresses a breaking change introduced by the removal of `add_auth_token(s)` methods in #182. To ensure backward compatibility and facilitate a smoother upgrade path, these methods are now reintroduced but explicitly marked as **deprecated**. Users are encouraged to migrate to the new `add_auth_token_getter(s)` methods instead. > [!NOTE] > The `strict` flag in the deprecated methods are not used anymore since the functionality of the `strict` flag has been changed (see #205 for more details).
anubhav756
added a commit
that referenced
this pull request
May 10, 2025
…lity This PR addresses a breaking change introduced by the removal of `add_auth_token(s)` methods in #182. To ensure backward compatibility and facilitate a smoother upgrade path, these methods are now reintroduced but explicitly marked as **deprecated**. Users are encouraged to migrate to the new `add_auth_token_getter(s)` methods instead. > [!NOTE] > The `strict` flag in the deprecated methods are not used anymore since the functionality of the `strict` flag has been changed (see #205 for more details).
anubhav756
added a commit
that referenced
this pull request
May 12, 2025
…lity This PR addresses a breaking change introduced by the removal of `add_auth_token(s)` methods in #182. To ensure backward compatibility and facilitate a smoother upgrade path, these methods are now reintroduced but explicitly marked as **deprecated**. Users are encouraged to migrate to the new `add_auth_token_getter(s)` methods instead. > [!NOTE] > The `strict` flag in the deprecated methods are not used anymore since the functionality of the `strict` flag has been changed (see #205 for more details).
anubhav756
added a commit
that referenced
this pull request
May 14, 2025
…lity This PR addresses a breaking change introduced by the removal of `add_auth_token(s)` methods in #182. To ensure backward compatibility and facilitate a smoother upgrade path, these methods are now reintroduced but explicitly marked as **deprecated**. Users are encouraged to migrate to the new `add_auth_token_getter(s)` methods instead. > [!NOTE] > The `strict` flag in the deprecated methods are not used anymore since the functionality of the `strict` flag has been changed (see #205 for more details).
anubhav756
added a commit
that referenced
this pull request
May 14, 2025
…lity This PR addresses a breaking change introduced by the removal of `add_auth_token(s)` methods in #182. To ensure backward compatibility and facilitate a smoother upgrade path, these methods are now reintroduced but explicitly marked as **deprecated**. Users are encouraged to migrate to the new `add_auth_token_getter(s)` methods instead. > [!NOTE] > The `strict` flag in the deprecated methods are not used anymore since the functionality of the `strict` flag has been changed (see #205 for more details).
anubhav756
added a commit
that referenced
this pull request
May 14, 2025
…lity This PR addresses a breaking change introduced by the removal of `add_auth_token(s)` methods in #182. To ensure backward compatibility and facilitate a smoother upgrade path, these methods are now reintroduced but explicitly marked as **deprecated**. Users are encouraged to migrate to the new `add_auth_token_getter(s)` methods instead. > [!NOTE] > The `strict` flag in the deprecated methods are not used anymore since the functionality of the `strict` flag has been changed (see #205 for more details).
anubhav756
added a commit
that referenced
this pull request
May 14, 2025
…lity This PR addresses a breaking change introduced by the removal of `add_auth_token(s)` methods in #182. To ensure backward compatibility and facilitate a smoother upgrade path, these methods are now reintroduced but explicitly marked as **deprecated**. Users are encouraged to migrate to the new `add_auth_token_getter(s)` methods instead. > [!NOTE] > The `strict` flag in the deprecated methods are not used anymore since the functionality of the `strict` flag has been changed (see #205 for more details).
anubhav756
added a commit
that referenced
this pull request
May 14, 2025
…lity This PR addresses a breaking change introduced by the removal of `add_auth_token(s)` methods in #182. To ensure backward compatibility and facilitate a smoother upgrade path, these methods are now reintroduced but explicitly marked as **deprecated**. Users are encouraged to migrate to the new `add_auth_token_getter(s)` methods instead. > [!NOTE] > The `strict` flag in the deprecated methods are not used anymore since the functionality of the `strict` flag has been changed (see #205 for more details).
anubhav756
added a commit
that referenced
this pull request
May 14, 2025
…lity This PR addresses a breaking change introduced by the removal of `add_auth_token(s)` methods in #182. To ensure backward compatibility and facilitate a smoother upgrade path, these methods are now reintroduced but explicitly marked as **deprecated**. Users are encouraged to migrate to the new `add_auth_token_getter(s)` methods instead. > [!NOTE] > The `strict` flag in the deprecated methods are not used anymore since the functionality of the `strict` flag has been changed (see #205 for more details).
anubhav756
added a commit
that referenced
this pull request
May 15, 2025
…lity This PR addresses a breaking change introduced by the removal of `add_auth_token(s)` methods in #182. To ensure backward compatibility and facilitate a smoother upgrade path, these methods are now reintroduced but explicitly marked as **deprecated**. Users are encouraged to migrate to the new `add_auth_token_getter(s)` methods instead. > [!NOTE] > The `strict` flag in the deprecated methods are not used anymore since the functionality of the `strict` flag has been changed (see #205 for more details).
anubhav756
added a commit
that referenced
this pull request
May 15, 2025
…lity This PR addresses a breaking change introduced by the removal of `add_auth_token(s)` methods in #182. To ensure backward compatibility and facilitate a smoother upgrade path, these methods are now reintroduced but explicitly marked as **deprecated**. Users are encouraged to migrate to the new `add_auth_token_getter(s)` methods instead. > [!NOTE] > The `strict` flag in the deprecated methods are not used anymore since the functionality of the `strict` flag has been changed (see #205 for more details).
anubhav756
added a commit
that referenced
this pull request
May 16, 2025
…lity This PR addresses a breaking change introduced by the removal of `add_auth_token(s)` methods in #182. To ensure backward compatibility and facilitate a smoother upgrade path, these methods are now reintroduced but explicitly marked as **deprecated**. Users are encouraged to migrate to the new `add_auth_token_getter(s)` methods instead. > [!NOTE] > The `strict` flag in the deprecated methods are not used anymore since the functionality of the `strict` flag has been changed (see #205 for more details).
anubhav756
added a commit
that referenced
this pull request
May 16, 2025
…lity This PR addresses a breaking change introduced by the removal of `add_auth_token(s)` methods in #182. To ensure backward compatibility and facilitate a smoother upgrade path, these methods are now reintroduced but explicitly marked as **deprecated**. Users are encouraged to migrate to the new `add_auth_token_getter(s)` methods instead. > [!NOTE] > The `strict` flag in the deprecated methods are not used anymore since the functionality of the `strict` flag has been changed (see #205 for more details).
anubhav756
added a commit
that referenced
this pull request
May 16, 2025
…lity This PR addresses a breaking change introduced by the removal of `add_auth_token(s)` methods in #182. To ensure backward compatibility and facilitate a smoother upgrade path, these methods are now reintroduced but explicitly marked as **deprecated**. Users are encouraged to migrate to the new `add_auth_token_getter(s)` methods instead. > [!NOTE] > The `strict` flag in the deprecated methods are not used anymore since the functionality of the `strict` flag has been changed (see #205 for more details).
anubhav756
added a commit
that referenced
this pull request
May 16, 2025
…lity This PR addresses a breaking change introduced by the removal of `add_auth_token(s)` methods in #182. To ensure backward compatibility and facilitate a smoother upgrade path, these methods are now reintroduced but explicitly marked as **deprecated**. Users are encouraged to migrate to the new `add_auth_token_getter(s)` methods instead. > [!NOTE] > The `strict` flag in the deprecated methods are not used anymore since the functionality of the `strict` flag has been changed (see #205 for more details).
anubhav756
added a commit
that referenced
this pull request
May 16, 2025
…lity This PR addresses a breaking change introduced by the removal of `add_auth_token(s)` methods in #182. To ensure backward compatibility and facilitate a smoother upgrade path, these methods are now reintroduced but explicitly marked as **deprecated**. Users are encouraged to migrate to the new `add_auth_token_getter(s)` methods instead. > [!NOTE] > The `strict` flag in the deprecated methods are not used anymore since the functionality of the `strict` flag has been changed (see #205 for more details).
anubhav756
added a commit
that referenced
this pull request
May 16, 2025
…lity This PR addresses a breaking change introduced by the removal of `add_auth_token(s)` methods in #182. To ensure backward compatibility and facilitate a smoother upgrade path, these methods are now reintroduced but explicitly marked as **deprecated**. Users are encouraged to migrate to the new `add_auth_token_getter(s)` methods instead. > [!NOTE] > The `strict` flag in the deprecated methods are not used anymore since the functionality of the `strict` flag has been changed (see #205 for more details).
anubhav756
added a commit
that referenced
this pull request
May 16, 2025
…lity This PR addresses a breaking change introduced by the removal of `add_auth_token(s)` methods in #182. To ensure backward compatibility and facilitate a smoother upgrade path, these methods are now reintroduced but explicitly marked as **deprecated**. Users are encouraged to migrate to the new `add_auth_token_getter(s)` methods instead. > [!NOTE] > The `strict` flag in the deprecated methods are not used anymore since the functionality of the `strict` flag has been changed (see #205 for more details).
anubhav756
added a commit
that referenced
this pull request
May 16, 2025
…lity (#236) * fix(toolbox-langchain)!: Base toolbox-langchain over toolbox-core * fix: add toolbox-core as package dependency * fix: Base sync client * fix: Fix running background asyncio in current loop issue * fix: Base toolbox sync & async tools to toolbox core counterparts * fix: Fix getting pydantic model from ToolboxSyncTool * fix: Fix issue causing async core tools for creating sync tools * fix: Fix reading name from correct param * fix: Fix issue of unknown parameter due to pydantic initialization * fix: Fix nit error + add comment * fix: Fix sync tool name assertion * chore: Temporarily remove unittests * chore: Remove unused strict flag + fix default values + fix docstring * fix: Update package to be from git repo * fix: Fix toolbox-core package local path * fix: Fix local package path * fix: Update git path * fix: Fix tests * fix: Fix using correct object for fetching loop * fix: Return invoke result * fix: Integration test errors * chore: Delint * fix: Fix integration test * fix: Fix integration tests * chore: Add unit tests previously deleted * chore: Delint * fix: Fix using correct protected member variables * chore: Delint * chore: Fix types * fix: Ensure bg loop/thread not null * fix: Check bg loop/thread value * fix: Revert warnings to prefer auth_tokens over auth_headers * chore: Update unittests * docs: Improve docstrings * chore: Add TODO note * chore: Improve TODO note * fix: Fix integration test * chore: Delint * chore: Rename internal member variable names to be more concise * chore: Delint * chore: Add toolbox actual package version in toml and local path in requirements.txt * fix: Fix editable toolbox-core package path in requirements.txt * fix: Fix lowest supported version until released * fix: Fix issue causing relative path in requirements.txt to cause issues * docs: Fix issue README * fix: Use correct core client interfaces in langchain client * fix: Use correct core tool interfaces in langchain tool * fix: Use correct interface from core tool * fix: Use correct interfaces of toolbox-core * chore: Update async client unit tests * chore: Fix client unit tests * chore: Delint * chore: Fix tools unit tests * chore: Restore add_auth_token(s) as deprecated for backward compatibility This PR addresses a breaking change introduced by the removal of `add_auth_token(s)` methods in #182. To ensure backward compatibility and facilitate a smoother upgrade path, these methods are now reintroduced but explicitly marked as **deprecated**. Users are encouraged to migrate to the new `add_auth_token_getter(s)` methods instead. > [!NOTE] > The `strict` flag in the deprecated methods are not used anymore since the functionality of the `strict` flag has been changed (see #205 for more details).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
load_toolandload_toolsetmethods (and their async counterpartsaload_tool,aload_toolset) within thetoolbox-langchainpackage, rename theauth_tokensparameter toauth_token_getters.auth_tokensparameter.This is to align with the
toolbox-coreAPIs and also because the suffix of_getter(s)make these APIs more descriptive and accurate.Because of the
_gettersuggesting it should be a function rather than a value, it actively encourages best practices regarding token security and lifecycle management (like refresh logic), which is crucial for production systems.